-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix image to text node, it was bugged #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
""" | ||
Gemini module configuration | ||
""" | ||
from langchain_google_genai import ChatGoogleGenerativeAI | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
""" | ||
""" | ||
Module for the ImageToTextNode class. | ||
""" | ||
|
||
from typing import List | ||
from .base_node import BaseNode | ||
|
||
|
||
|
@@ -10,34 +10,43 @@ class ImageToTextNode(BaseNode): | |
A class representing a node that processes an image and returns the text description. | ||
|
||
Attributes: | ||
llm (OpenAIImageToText): An instance of the OpenAIImageToText class. | ||
llm_model (OpenAIImageToText): An instance of the OpenAIImageToText class. | ||
|
||
Methods: | ||
execute(state, url): Execute the node's logic and return the updated state. | ||
""" | ||
|
||
def __init__(self, llm, node_name: str): | ||
def __init__(self, input: str, output: List[str], model_config: dict, | ||
node_name: str = "ImageToText"): | ||
""" | ||
Initializes an instance of the ImageToTextNode class. | ||
|
||
Args: | ||
llm (OpenAIImageToText): An instance of the OpenAIImageToText class. | ||
node_name (str): name of the node | ||
input (str): The input for the node. | ||
output (List[str]): The output of the node. | ||
model_config (dict): Configuration for the model. | ||
node_name (str): Name of the node. | ||
""" | ||
super().__init__(node_name, "node") | ||
self.llm = llm | ||
super().__init__(node_name, "node", input, output, 1, model_config) | ||
self.llm_model = model_config["llm_model"] | ||
|
||
def execute(self, state: dict, url: str) -> dict: | ||
def execute(self, state: dict) -> dict: | ||
""" | ||
Execute the node's logic and return the updated state. | ||
|
||
Args: | ||
state (dict): The current state of the graph. | ||
url (str): url of the image where to | ||
:return: The updated state after executing this node. | ||
""" | ||
|
||
Returns: | ||
dict: The updated state after executing this node. | ||
""" | ||
print("---GENERATING TEXT FROM IMAGE---") | ||
text_answer = self.llm.run(url) | ||
input_keys = self.get_input_keys(state) | ||
|
||
input_data = [state[key] for key in input_keys] | ||
url = input_data[0] | ||
|
||
text_answer = self.llm_model.run(url) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing the retrieval part from the state before this line to get the url |
||
state.update({"image_text": text_answer}) | ||
return state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope