opt_clean: handle undriven and x-bit driven bits consistently #5004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe driving the bit of a signal with a constant x-bit is exactly the same as not driving it at all. This PR removes this inconsistency by extending
SigPool
. As theSigPool
is used to check theassign_map
ped wire bits against unmapped bits, this creates an arbitrary distinction between driven and undriven. I have added a pass-specific mechanism by inheriting fromSigPool
that happens to work for this case. I don't know ifSigPool
is similarly misused elsewhere.This PR shares its motivation with #5003