Skip to content

KAFKA-17834 Improvement the Dockerfile #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

m1a2st
Copy link
Collaborator

@m1a2st m1a2st commented Oct 19, 2024

Jira: https://issues.apache.org/jira/browse/KAFKA-17834

This PR fixed thress dockerfile warning:

  1. MaintainerDeprecated
  2. LegacyKeyValueFormat
  3. JSONArgsRecommended

If have any warning, It will show in console like
CleanShot 2024-10-19 at 23 59 02@2x

I ran on my local machine: It won't show any warning
CleanShot 2024-10-19 at 23 58 06@2x

The e2e test also can run and pass
CleanShot 2024-10-20 at 00 16 36@2x

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Oct 19, 2024
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m1a2st thanks for this improvement!

@@ -153,4 +153,4 @@ RUN useradd -u $UID -ms /bin/bash ducker \

USER ducker

CMD sudo service ssh start && tail -f /dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use the tail to make the container alive, and that can be replaced by detaching the sshd. Hence, could you please try to use CMD ["sudo", "service", "ssh", "start", "-D"] instaead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can pass on my local
image

@chia7712
Copy link
Member

@m1a2st Could you please rebase code?

@github-actions github-actions bot added the docker Official Docker image label Jan 12, 2025
@m1a2st m1a2st changed the title KAFKA-17834 Improvement the e2e Dockerfile KAFKA-17834 Improvement the Dockerfile Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved docker Official Docker image small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants