-
Notifications
You must be signed in to change notification settings - Fork 14.4k
KAFKA-17834 Improvement the Dockerfile #17554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
reference:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m1a2st thanks for this improvement!
@@ -153,4 +153,4 @@ RUN useradd -u $UID -ms /bin/bash ducker \ | |||
|
|||
USER ducker | |||
|
|||
CMD sudo service ssh start && tail -f /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use the tail
to make the container alive, and that can be replaced by detaching the sshd. Hence, could you please try to use CMD ["sudo", "service", "ssh", "start", "-D"]
instaead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m1a2st Could you please rebase code? |
Jira: https://issues.apache.org/jira/browse/KAFKA-17834
This PR fixed thress dockerfile warning:
If have any warning, It will show in console like

I ran on my local machine: It won't show any warning

The e2e test also can run and pass

Committer Checklist (excluded from commit message)