Skip to content

KAFKA-17834 Improvement the Dockerfile #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-17834 Improvement the Dockerfile #17554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
892f7fe
improvement docker file
m1a2st Oct 19, 2024
95359ba
Merge branch 'trunk' into KAFKA-17834
m1a2st Nov 18, 2024
54edeac
addressed by comment
m1a2st Nov 18, 2024
b7a8a78
Merge branch 'trunk' into KAFKA-17834
m1a2st Nov 30, 2024
ba17263
Merge branch 'trunk' into KAFKA-17834
m1a2st Jan 12, 2025
24e9517
change to maintainer to `org.opencontainers.image.authors`
m1a2st Jan 12, 2025
703225d
Merge branch 'trunk' into KAFKA-17834
m1a2st Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/jvm/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ LABEL org.label-schema.name="kafka" \
org.label-schema.description="Apache Kafka" \
org.label-schema.build-date="${build_date}" \
org.label-schema.vcs-url="https://github.com/apache/kafka" \
maintainer="Apache Kafka"
org.opencontainers.image.authors="Apache Kafka"

RUN set -eux ; \
apk update ; \
Expand Down
2 changes: 1 addition & 1 deletion docker/native/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ LABEL org.label-schema.name="kafka" \
org.label-schema.description="Apache Kafka" \
org.label-schema.build-date="${build_date}" \
org.label-schema.vcs-url="https://github.com/apache/kafka" \
maintainer="Apache Kafka"
org.opencontainers.image.authors="Apache Kafka"

RUN apk update ; \
apk add --no-cache gcompat ; \
Expand Down
6 changes: 3 additions & 3 deletions tests/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ RUN if [ "$KAFKA_MODE" = "native" ]; then \

FROM $jdk_version

MAINTAINER Apache Kafka dev@kafka.apache.org
LABEL org.opencontainers.image.authors="Apache Kafka dev@kafka.apache.org"
VOLUME ["/opt/kafka-dev"]

# Set the timezone.
ENV TZ="/usr/share/zoneinfo/America/Los_Angeles"

# Do not ask for confirmations when running apt-get, etc.
ENV DEBIAN_FRONTEND noninteractive
ENV DEBIAN_FRONTEND=noninteractive

# Set the ducker.creator label so that we know that this is a ducker image. This will make it
# visible to 'ducker purge'. The ducker.creator label also lets us know what UNIX user built this
Expand Down Expand Up @@ -153,4 +153,4 @@ RUN useradd -u $UID -ms /bin/bash ducker \

USER ducker

CMD sudo service ssh start && tail -f /dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use the tail to make the container alive, and that can be replaced by detaching the sshd. Hence, could you please try to use CMD ["sudo", "service", "ssh", "start", "-D"] instaead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can pass on my local
image

CMD ["sudo", "service", "ssh", "start", "-D"]