Enable accessibility features for the button example #18749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessibility systems will recognise it.
ickshonpe
added
C-Examples
djeedai
approved these changes
Apr 19, 2025
greeble-dev
approved these changes
Apr 25, 2025
… changes to hovered or pressed. The accessibility system's only update the button's state when the `Button` component is marked as changed.
…shonpe/bevy into button-example-accessibility
Yep, now the screen reader should report "hovered" when the button is hovered and "pressed" when the button is pressed. |
ickshonpe
added
S-Ready-For-Final-Review
ickshonpe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Accessibility features don't work with the UI
buttonexample becauseInputFocusmust be set for the accessibility systems to recognise the button.Fixes #18760
Solution
InputFocuswhen it is hovered or pressed.set_changedon theButtoncomponent when the button's state changes to hovered or pressed (the accessibility system's only update the button's state when theButtoncomponent is marked as changed).Testing
Install NVDA, it should say "hover" when the button is hovered and "pressed" when the button is pressed.
The bounds of the accessibility node are reported incorrectly. I thought we fixed this, I'll take another look at it. It's not a problem with this PR.