feat(backend): add contact type and address type. #5815
Conversation
SYInacta
changed the title
…com/dfinity/oisy-wallet into feat/(backend)/contacts-shared-type
| } | ||
|
|
||
| #[derive(CandidType, Deserialize, Clone, Debug, Eq, PartialEq)] | ||
| pub enum AddressType { |
There was a problem hiding this comment.
Note: You may want to sync with @AntonioVentilii on this list. We could have a meeting with the three of us. In particular:
-
We support testnets as well as mainnets for each network, so some clarity is needed: is this a list of protocols, or is it "where to send the message"? E.g. what is the addressType for ckBTC (which is BTC, but using the ICP protocol), what is the address type for a Solana Testnet address, what is the address type for a Solana Devnet Account?
-
There is a risk of having several lists of networks that are all slightly different. One for snapshots, one for rewards, one for rewards, and so on. It might be an idea to have a single list of networks and a single list of protocols.
There was a problem hiding this comment.
As discussed, maybe move this to shared/types/?
⭐ PR 1: Implement necessary changes in shared for Contacts feature
Motivation
Provide the shared type, contacts structures and logic, including challenge creation, update, and delete of contacts and addresses associated to those contact.
Changes
Introduced a new rust module contacts in shared
Added the necessary candid structures
Tests