Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(backend): add contact type and address type. #5815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(backend): add contact type and address type. #5815
Changes from 9 commits
e96a4e3
d0ab49f
5548426
f1818dd
ebc6229
3c7b5e3
a2450d5
7f080f7
095d685
bbf6f60
3eb9fc3
5d5f1b7
3994581
a45c702
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: You may want to sync with @AntonioVentilii on this list. We could have a meeting with the three of us. In particular:
We support testnets as well as mainnets for each network, so some clarity is needed: is this a list of protocols, or is it "where to send the message"? E.g. what is the addressType for ckBTC (which is BTC, but using the ICP protocol), what is the address type for a Solana Testnet address, what is the address type for a Solana Devnet Account?
There is a risk of having several lists of networks that are all slightly different. One for snapshots, one for rewards, one for rewards, and so on. It might be an idea to have a single list of networks and a single list of protocols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, maybe move this to
shared/types/
?