Skip to content

Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only #118815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 17, 2024
Merged

Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only #118815

merged 7 commits into from
Dec 17, 2024

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Dec 17, 2024 •
edited
Loading

Fixes #118814
Fixes #118810

@astefan astefan added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged test-release Trigger CI checks against release build :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@carlosdelest
Copy link
Member

This is also failing in 8.17 (see this PR), tagging backport for that version

@astefan astefan removed the v8.17.0 label Dec 17, 2024
alex-spies
alex-spies approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @astefan !

This was referenced Dec 17, 2024
Merged
Merged
craigtaverner
craigtaverner requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the wrong capability was used. These queries use LOOKUP JOIN, so sufrely the JOIN_LOOKUP_V6 capability should be the one to use?

@astefan astefan removed the test-release Trigger CI checks against release build label Dec 17, 2024
@alex-spies
Copy link
Contributor

@craigtaverner this uses the correct capability now, and should be fine to be merged :)

@carlosdelest carlosdelest mentioned this pull request Dec 17, 2024
Closed
@astefan astefan merged commit e0763c2 into elastic:main Dec 17, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118815

@astefan astefan mentioned this pull request Dec 17, 2024
Closed
astefan added a commit to astefan/elasticsearch that referenced this pull request Dec 17, 2024
@astefan
Mark the lookup join tests in IndexResolverFieldNamesTests as snapsho…
133d46b 
…t-only (elastic#118815)

(cherry picked from commit e0763c2)
This was referenced Dec 17, 2024
Merged
Closed
@astefan astefan deleted the 118814_fix branch December 17, 2024 15:34
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2024
@astefan
Mark the lookup join tests in IndexResolverFieldNamesTests as snapsho…
81697b0 
…t-only (#118853)

* Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only (#118815)

(cherry picked from commit e0763c2)

* Unmute the sql test
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
@astefan @navarone-feekery
Mark the lookup join tests in IndexResolverFieldNamesTests as snapsho…
0287ff0 
…t-only (elastic#118815)
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Jan 7, 2025
@astefan
Mark the lookup join tests in IndexResolverFieldNamesTests as snapsho…
d444dd8 
…t-only (elastic#118815)

(cherry picked from commit e0763c2)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/session/IndexResolverFieldNamesTests.java
@carlosdelest
Copy link
Member

💚 All backports created successfully

Status Branch Result
✅ 8.15

Questions ?

Please refer to the Backport tool documentation

@carlosdelest carlosdelest mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-spies alex-spies alex-spies approved these changes

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@craigtaverner craigtaverner Awaiting requested review from craigtaverner

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] IndexResolverFieldNamesTests class failing [CI] JdbcDocCsvSpecIT test {docs.testFilterToday} failing
6 participants
@astefan @elasticsearchmachine @carlosdelest @alex-spies @craigtaverner @idegtiarenko