Skip to content

Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only #118815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only #118815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba9c73f
Mark the lookup join tests in IndexResolverFieldNamesTests as snapsho…
astefan Dec 17, 2024
26d0508
Fix a perfectly-timed failure due to years change
astefan Dec 17, 2024
c7e3368
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Dec 17, 2024
4d6f654
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Dec 17, 2024
e2279e3
Change the capability
astefan Dec 17, 2024
a14af34
Forgot three updates
astefan Dec 17, 2024
783f2b6
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,6 @@ tests:
- class: org.elasticsearch.xpack.security.QueryableReservedRolesIT
method: testDeletingAndCreatingSecurityIndexTriggersSynchronization
issue: https://github.com/elastic/elasticsearch/issues/118806
- class: org.elasticsearch.xpack.esql.session.IndexResolverFieldNamesTests
issue: https://github.com/elastic/elasticsearch/issues/118814
- class: org.elasticsearch.index.engine.RecoverySourcePruneMergePolicyTests
method: testPruneSome
issue: https://github.com/elastic/elasticsearch/issues/118728
Expand Down
13 changes: 13 additions & 0 deletions ...esql/src/test/java/org/elasticsearch/xpack/esql/session/IndexResolverFieldNamesTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import org.elasticsearch.Build;
import org.elasticsearch.test.ESTestCase;
import org.elasticsearch.xpack.esql.action.EsqlCapabilities;
import org.elasticsearch.xpack.esql.parser.EsqlParser;
import org.elasticsearch.xpack.esql.parser.ParsingException;

Expand Down Expand Up @@ -1364,6 +1365,7 @@ public void testMetrics() {
}

public void testLookupJoin() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"FROM employees | KEEP languages | RENAME languages AS language_code | LOOKUP JOIN languages_lookup ON language_code",
Set.of("languages", "languages.*", "language_code", "language_code.*"),
Expand All @@ -1372,6 +1374,7 @@ public void testLookupJoin() {
}

public void testLookupJoinKeep() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM employees
Expand All @@ -1385,6 +1388,7 @@ public void testLookupJoinKeep() {
}

public void testLookupJoinKeepWildcard() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM employees
Expand All @@ -1398,6 +1402,7 @@ public void testLookupJoinKeepWildcard() {
}

public void testMultiLookupJoin() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1410,6 +1415,7 @@ public void testMultiLookupJoin() {
}

public void testMultiLookupJoinKeepBefore() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1423,6 +1429,7 @@ public void testMultiLookupJoinKeepBefore() {
}

public void testMultiLookupJoinKeepBetween() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1447,6 +1454,7 @@ public void testMultiLookupJoinKeepBetween() {
}

public void testMultiLookupJoinKeepAfter() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1473,6 +1481,7 @@ public void testMultiLookupJoinKeepAfter() {
}

public void testMultiLookupJoinKeepAfterWildcard() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1486,6 +1495,7 @@ public void testMultiLookupJoinKeepAfterWildcard() {
}

public void testMultiLookupJoinSameIndex() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1499,6 +1509,7 @@ public void testMultiLookupJoinSameIndex() {
}

public void testMultiLookupJoinSameIndexKeepBefore() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1513,6 +1524,7 @@ public void testMultiLookupJoinSameIndexKeepBefore() {
}

public void testMultiLookupJoinSameIndexKeepBetween() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand All @@ -1538,6 +1550,7 @@ public void testMultiLookupJoinSameIndexKeepBetween() {
}

public void testMultiLookupJoinSameIndexKeepAfter() {
assumeTrue("LOOKUP JOIN available as snapshot only", EsqlCapabilities.Cap.JOIN_LOOKUP_V7.isEnabled());
assertFieldNames(
"""
FROM sample_data
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/sql/qa/server/src/main/resources/docs/docs.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3353,7 +3353,7 @@ Alejandro
Amabile
Anoosh
Basil
Bojan
Brendon
// end::filterToday
;

Expand Down