[naga]: Add no_std
polyfill for round_ties_even
for f32
and f64
#7585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
round_ties_even
f16
polyfill forf32
andf64
usingnum_traits::float::FloatCore
, specifically forno_std
supportnaga
to the Checkno_std
CI action now that it is MVP compatibleTesting
Squash or Rebase?
Squash
Checklist
cargo fmt
.RunN/Ataplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.Notes
f32::round_ties_even
orf64::round_ties_even
, since I don't believe there is substantial value added with such a feature.f16
polyfill. However, there are substantial tests for this exact method in this num-traits PR I opened. This PR would just allow us to continue working onno_std
support while we wait for that PR to be accepted (or not).