Fix various trivial frontend problems #34263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wxiaoguang
commented
Apr 23, 2025
•
wxiaoguang
commented
- Fix Many images don't have an alt attribute #20606
- Fix Inconsistent emoji display (emoji font ordering issue) #34246
- Fix missing spaces, fix misspells, no visual change.
- Fix missing "not-mobile", fix Shrink down Buttons with Labels to Icons when in mobile mode #34265
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
This was referenced Apr 23, 2025
wxiaoguang
force-pushed
the
fix-frontend-trivials
branch
from
d61a041 to
7454bb0
Compare
lunny
reviewed
Apr 23, 2025
lunny
approved these changes
Apr 23, 2025
GiteaBot
added
lgtm/need 1
|
And fix missing "not-mobile":
|
silverwind
reviewed
Apr 23, 2025
web_src/css/base.css
Outdated
| @@ -2,7 +2,8 @@ | |||
| /* fonts */ | |||
| --fonts-proportional: -apple-system, "Segoe UI", system-ui, Roboto, "Helvetica Neue", Arial; | |||
| --fonts-monospace: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace, var(--fonts-emoji); | |||
| --fonts-emoji: "Apple Color Emoji", "Segoe UI Emoji", "Noto Color Emoji", "Twemoji Mozilla"; | |||
| /* "Twemoji Mozilla" emoji font is widely used by browsers like Firefox, Pale Moon, and it is more likely up-to-dated than the system emoji font */ | |||
| --fonts-emoji: "Twemoji Mozilla", "Apple Color Emoji", "Segoe UI Emoji", "Noto Color Emoji"; | |||
There was a problem hiding this comment.
See #34246 (comment). Maybe we should set --fonts-emoji to a empty value, letting the browser choose the right font? Empty so that customization still works with the variable.
There was a problem hiding this comment.
Or better yet, just remove --fonts-emoji altogether. Users can still alter the other vars if they want to override emoji fonts.
There was a problem hiding this comment.
Maybe like this: 0b04bfb. then the var is still kept and won't cause too many changes and the var could still be customized.
There was a problem hiding this comment.
I suppose a dummy won't hurt but I see no real reason to retain the variable either.
There was a problem hiding this comment.
There are 2 reasons in my mind:
- There are not only one references to
--fonts-emoji, I don't want to introduce too many changes or do more tests. - Keeping the dummy name makes it easier to revert in the future (if anything wrong). We can fully remove the dummy name in future releases if it has been widely tested and there wouldn't be any problem.
delvh
changed the title
delvh
approved these changes
Apr 23, 2025
GiteaBot
added
lgtm/done
silverwind
reviewed
Apr 23, 2025
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Apr 24, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 24, 2025
* giteaofficial/main: Fix panic when comment is nil (go-gitea#34257) Fix various trivial frontend problems (go-gitea#34263) update go&js dependencies (go-gitea#34262) Fix runner list tmpl (go-gitea#34270) Improve "not found" error messages for API (go-gitea#34267) Add fullscreen mode as a more efficient operation way to view projects (go-gitea#34081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.