refactor: delete sim error #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 7, 2025
dylanlott
approved these changes
May 8, 2025
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
e9e835b to
aa49dc4
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
bbc4464 to
baed5bb
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
aa49dc4 to
f6843d0
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
baed5bb to
8ca41bf
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
f6843d0 to
2f7b513
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
8ca41bf to
a1b1582
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
2f7b513 to
cc9f11c
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
2 times, most recently
from
3f16799 to
eb33cb3
Compare
prestwich
force-pushed
the
prestwich/fix-metrics
branch
2 times, most recently
from
710eacb to
f447e78
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
eb33cb3 to
5c6629e
Compare
Merged
prestwich
force-pushed
the
prestwich/fix-metrics
branch
from
f447e78 to
bf796ed
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
5c6629e to
b8f712b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deletes the sim error type, which is a 1-variant enum. we can add this back later if we want to differentiate