refactor: misc cleaning on the submit task #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2025
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
30ea085 to
073dc7a
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
bbc4464 to
baed5bb
Compare
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
073dc7a to
c7ca987
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
2 times, most recently
from
8ca41bf to
a1b1582
Compare
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
c7ca987 to
2d4c4e6
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
a1b1582 to
3f16799
Compare
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
2d4c4e6 to
15d0c95
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
3f16799 to
eb33cb3
Compare
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
2 times, most recently
from
db4fdbd to
88a94dc
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
eb33cb3 to
5c6629e
Compare
Merged
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
88a94dc to
8f2e1e9
Compare
prestwich
force-pushed
the
prestwich/delete-sim-error
branch
from
5c6629e to
b8f712b
Compare
prestwich
force-pushed
the
prestwich/clean-submit-task
branch
from
8f2e1e9 to
4028fe0
Compare
Evalir
approved these changes
May 9, 2025
| break; | ||
| error!("error handling inbound block: retrying"); | ||
| drop(guard); | ||
| tokio::time::sleep(tokio::time::Duration::from_secs(2)).await; |
There was a problem hiding this comment.
should we maybe wait a sec less? 2 is quite a bit from a slot time perspective
There was a problem hiding this comment.
im not making a behavior change, just cleaning
This was referenced May 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the submit task by breaking up functions more and improving tracing and control flow