Skip to content

Added functionality to add go to edit page button on admin grid inline edit #27614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

niravkrish
Copy link
Contributor

@niravkrish niravkrish commented Apr 5, 2020

Description (*)

  • I have created functionality to allow customer to easily add edit page URL to grid inline edit by using XML configuration in listing UI component.
    See the screenshot.
    screenshot-nimbus-capture-2020 04 05-11_26_28

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes UX issue on Admin > Content > Pages/Blocks grid #27550 : UX issue on Admin > Content > Pages/Blocks grid

Manual testing scenarios (*)

  1. Manual Testing in different grid and check redirection functionality.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Apr 5, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 5, 2020

Hi @niravkrish. Thank you for you collaboration. I'm putting it on hold for the internal discussion of the best approach.

@ghost ghost removed the Progress: pending review label Apr 5, 2020
@ghost ghost added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jul 30, 2020
@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Aug 14, 2020
@ihor-sviziev
Copy link
Contributor

@rogyar any updates on internal discussion?

@rogyar
Copy link
Contributor

rogyar commented Sep 6, 2020

Hi @ihor-sviziev. POs was supposed to get back to this PR for the review. Let's move it to the corresponding status to speed up the process.

Thank you for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Cms Component: Ui Event: Global-Contribution-Day Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: to approve Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Status: To Approve
Development

Successfully merging this pull request may close these issues.

UX issue on Admin > Content > Pages/Blocks grid
4 participants