Skip to content

Clean unneccesary prefix flexbox #30923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Draft

Clean unneccesary prefix flexbox #30923

wants to merge 2 commits into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Nov 14, 2020 •
edited
Loading

Description (*)

Wide major browsers update support flexbox so i think it's time for clear prefix flexbox!
In this PR i only clear prefix and keep name mixins for maintain compatible

2.3.x browser support
2.4.x browser support
From Open Source Edition 2.4+ magento drop support IE
https://death-to-ie11.com/ IE official deprecated by microsoft

From 2015 to present flexbox more support cross all major browsers. So we don't need prefix use

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

If this pr approve i have another pr introduce flexbox mixins (no use prefix)
#30666

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Clean unneccesary prefix flexbox #30932: Clean unneccesary prefix flexbox

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the clean-unneccesary-prefix-flex-box branch from 3c2f639 to 9770c12 Compare November 14, 2020 04:55
digiltd
digiltd reviewed Nov 14, 2020
View reviewed changes
Copy link

@digiltd digiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces before opening braces?

https://devdocs.magento.com/guides/v2.4/coding-standards/code-standard-less.html

@mrtuvn mrtuvn force-pushed the clean-unneccesary-prefix-flex-box branch from 9770c12 to 59fdb69 Compare November 14, 2020 13:26
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 14, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 16, 2020

@krzksz @Leland can you guys give a review this
Thanks

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 16, 2020
@sidolov
Copy link
Contributor

sidolov commented Nov 16, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 16, 2020
Closed
4 tasks
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 18, 2020

@magento run Functional Tests CE

@Leland
Copy link
Contributor

Leland commented Nov 18, 2020

All uses of these mixins should be removed and the mixins themselves deprecated, pending removal in a major version. Simply stripping the functionality out of the mixins isn't enough.

I wonder how we can sunset mixins in Magento 2. If this were SCSS we could use @warn

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 18, 2020 •
edited
Loading

I think we can add note deprecated and introduce new mixins also update doc for this. Old mixins still use anywhere and remove all of these will take time. Maybe next 2.5.x will need new clean up all usages
#30666
Here is another PR add new mixins we can reuseable!

@mrtuvn mrtuvn force-pushed the clean-unneccesary-prefix-flex-box branch 2 times, most recently from 969481a to 0e37656 Compare November 19, 2020 10:26
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 19, 2020

spaces before opening braces?

https://devdocs.magento.com/guides/v2.4/coding-standards/code-standard-less.html

This is unneccesary thing. We don't have to put space between

@digiltd
Copy link

digiltd commented Nov 22, 2020

spaces before opening braces?
https://devdocs.magento.com/guides/v2.4/coding-standards/code-standard-less.html

This is unneccesary thing. We don't have to put space between

sorry, my mistake, I saw them as braces not parentheses :)

@mrtuvn mrtuvn force-pushed the clean-unneccesary-prefix-flex-box branch from 0e37656 to 9040cac Compare November 26, 2020 00:20
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 27, 2020

@magento run all tests

@mrtuvn mrtuvn mentioned this pull request Dec 7, 2020
Closed
5 tasks
@m2-assistant m2-assistant bot mentioned this pull request Dec 7, 2020
Closed
4 tasks
@mrtuvn mrtuvn force-pushed the clean-unneccesary-prefix-flex-box branch from 9040cac to 6c086e0 Compare December 13, 2020 02:42
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 13, 2020

rebased PR branch with mainline code magento

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 13, 2020

@magento run all tests

@mrtuvn mrtuvn requested review from Leland and krzksz April 3, 2021 09:57
@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digiltd digiltd digiltd left review comments

@Leland Leland Awaiting requested review from Leland

@krzksz krzksz Awaiting requested review from krzksz

Assignees
No one assigned
Labels
Area: Lib/Frontend Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Clean unneccesary prefix flexbox
5 participants
@mrtuvn @sidolov @Leland @digiltd @magento-engcom-team