MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018

engcom-Echo · 2020-11-23T16:27:39Z

Description (*)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-11-23T16:27:44Z

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Echo · 2020-11-23T16:28:53Z

@magento run all tests

ihor-sviziev

Hi @engcom-Echo ,
Your change is definitely backward incompatible in the interface marked with @api tag that is prohibited in minor releases and will create a lot of issues for upgrade.

Could you do following things:

create new interface with your suggested changes
add implements in the repository
mark old interface as @deprecated due to issues listed in the related issue
add to the old interface new tag @see with new interface

ihor-sviziev · 2020-11-25T10:09:58Z

@engcom-Echo just an idea - can we do it as a plugin to existing "save" method?

ihor-sviziev · 2020-12-02T14:24:33Z

@engcom-Echo could you explain why this PR was moved to on-hold status?

ihor-sviziev · 2021-01-25T09:23:54Z

app/code/Magento/Quote/Api/AddCartItemInterface.php

+     * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart.
+     * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid.
+     */
+    public function execute(\Magento\Quote\Api\Data\CartItemInterface $cartItem);


Please declare the return type

ihor-sviziev · 2021-01-25T09:24:36Z

app/code/Magento/Quote/Api/UpdateCartItemInterface.php

+     * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart.
+     * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid.
+     */
+    public function execute(\Magento\Quote\Api\Data\CartItemInterface $cartItem);


Please declare return type here

ihor-sviziev · 2021-01-25T09:24:55Z

app/code/Magento/Quote/Model/Quote/Item/AddCartItem.php

+    /**
+     * @inheritDoc
+     */
+    public function execute(CartItemInterface $cartItem)


please add return type here

ihor-sviziev · 2021-01-25T09:25:06Z

app/code/Magento/Quote/Model/Quote/Item/UpdateCartItem.php

+    /**
+     * @inheritDoc
+     */
+    public function execute(CartItemInterface $cartItem)


ihor-sviziev · 2021-01-25T09:26:11Z

Please also check the failing WebApi tests

ihor-sviziev · 2021-01-25T15:33:58Z

@magento run all tests

engcom-Echo · 2021-01-25T15:50:13Z

@magento run all tests

engcom-Echo · 2021-01-25T19:18:05Z

@magento run all tests

engcom-Echo · 2021-01-25T21:48:39Z

@magento run WebAPI Tests

engcom-Echo · 2021-01-26T12:00:39Z

@magento run WebAPI Tests

gabrieldagama · 2021-01-26T15:03:48Z

@magento run all tests

engcom-Echo · 2021-01-26T18:17:25Z

@magento run all tests

engcom-Echo · 2021-01-27T07:17:40Z

@magento run all tests

engcom-Echo · 2021-01-27T09:54:26Z

@magento run WebAPI Tests

zakdma · 2021-01-28T09:44:52Z

app/code/Magento/Quote/etc/webapi.xml

@@ -177,13 +177,13 @@
        </resources>
    </route>
    <route url="/V1/carts/:quoteId/items" method="POST">
-        <service class="Magento\Quote\Api\CartItemRepositoryInterface" method="save"/>
+        <service class="Magento\Quote\Api\AddCartItemInterface" method="execute"/>


What about Guest carts? I suppose should be same logic there

zakdma · 2021-01-28T09:49:15Z

app/code/Magento/Quote/Api/CartItemRepositoryInterface.php

@@ -29,6 +29,11 @@ public function getList($cartId);
     * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist.
     * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart.
     * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid.
+     *
+     * @deprecated Post and put endpoint should be separated


Why its deprecated? It widely used in code (I mean implementation of this method) not only for API

zakdma · 2021-01-28T09:49:50Z

app/code/Magento/Quote/Api/UpdateCartItemInterface.php

+use Magento\Quote\Api\Data\CartItemInterface;
+
+/**
+ * Interface UpdateCartItemInterface


Please provide meaningful description for interface

zakdma · 2021-01-28T09:54:50Z

app/code/Magento/Quote/Api/AddCartItemInterface.php

+use Magento\Quote\Api\Data\CartItemInterface;
+
+/**
+ * Interface AddCartItemInterface


Please provide meaningful description for interface

ihor-sviziev · 2021-02-19T10:47:34Z

@engcom-Echo will you be able to update your PR?

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 23, 2020

magento-engcom-team added Component: Quote Release Line: 2.4 labels Nov 23, 2020

m2-community-project bot added the Progress: pending review label Nov 23, 2020

engcom-Echo requested review from engcom-Kilo, viktorpetryk and zakdma November 23, 2020 16:28

ihor-sviziev requested changes Nov 25, 2020

View reviewed changes

m2-community-project bot assigned ihor-sviziev Nov 25, 2020

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Nov 25, 2020

ihor-sviziev added Award: advanced Award: bug fix Progress: pending review and removed Progress: needs update labels Nov 25, 2020

m2-community-project bot removed the Progress: pending review label Nov 25, 2020

ihor-sviziev added Progress: needs update Progress: pending review labels Nov 25, 2020

m2-community-project bot added Progress: pending review Progress: needs update and removed Progress: needs update Progress: pending review labels Nov 25, 2020

engcom-Echo added the Progress: on hold label Dec 1, 2020

m2-community-project bot removed Progress: needs update Progress: pending review labels Dec 1, 2020

ihor-sviziev requested changes Jan 25, 2021

View reviewed changes

engcom-Echo added 3 commits January 25, 2021 17:04

MC-34298: Introduce separate POST and PUT API for carts/mine/items

e026cfb

MC-34298: Introduce separate POST and PUT API for carts/mine/items

b1081e7

MC-34298: Introduce separate POST and PUT API for carts/mine/items

a4f09a1

engcom-Echo force-pushed the MC-34298 branch from 5967c31 to a4f09a1 Compare January 25, 2021 15:06

ihor-sviziev added the Progress: review label Jan 25, 2021

m2-community-project bot added Progress: needs update and removed Progress: needs update Progress: review labels Jan 25, 2021

MC-34298: Introduce separate POST and PUT API for carts/mine/items

831b6f1

engcom-Echo force-pushed the MC-34298 branch from d36e297 to 831b6f1 Compare January 25, 2021 16:38

MC-34298: Introduce separate POST and PUT API for carts/mine/items

cb65f28

engcom-Echo requested a review from gabrieldagama January 27, 2021 11:55

zakdma suggested changes Jan 28, 2021

View reviewed changes

m2-community-project bot assigned zakdma Jan 28, 2021

ihor-sviziev added this to the 2.5 milestone Feb 19, 2021

gabrieldagama added Release Line: 2.5 and removed Release Line: 2.4 labels Mar 2, 2021

zakdma removed their assignment May 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018

MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018

engcom-Echo commented Nov 23, 2020 •

edited by gabrieldagama

Loading

m2-assistant bot commented Nov 23, 2020

engcom-Echo commented Nov 23, 2020

ihor-sviziev left a comment

ihor-sviziev commented Nov 25, 2020

ihor-sviziev commented Dec 2, 2020 •

edited

Loading

ihor-sviziev Jan 25, 2021

ihor-sviziev Jan 25, 2021

ihor-sviziev Jan 25, 2021

ihor-sviziev Jan 25, 2021

ihor-sviziev commented Jan 25, 2021

ihor-sviziev commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 26, 2021

gabrieldagama commented Jan 26, 2021

engcom-Echo commented Jan 26, 2021

engcom-Echo commented Jan 27, 2021

engcom-Echo commented Jan 27, 2021

zakdma Jan 28, 2021

zakdma Jan 28, 2021

zakdma Jan 28, 2021

zakdma Jan 28, 2021

ihor-sviziev commented Feb 19, 2021

MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018

Are you sure you want to change the base?

MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018

Conversation

engcom-Echo commented Nov 23, 2020 • edited by gabrieldagama Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Nov 23, 2020

engcom-Echo commented Nov 23, 2020

ihor-sviziev left a comment

Choose a reason for hiding this comment

ihor-sviziev commented Nov 25, 2020

ihor-sviziev commented Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ihor-sviziev commented Jan 25, 2021

ihor-sviziev commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 25, 2021

engcom-Echo commented Jan 26, 2021

gabrieldagama commented Jan 26, 2021

engcom-Echo commented Jan 26, 2021

engcom-Echo commented Jan 27, 2021

engcom-Echo commented Jan 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ihor-sviziev commented Feb 19, 2021

engcom-Echo commented Nov 23, 2020 •

edited by gabrieldagama

Loading

ihor-sviziev commented Dec 2, 2020 •

edited

Loading