MC-34298: Introduce separate POST and PUT API for carts/mine/items #31018
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\Quote\Api; | ||
|
|
||
| use Magento\Quote\Api\Data\CartItemInterface; | ||
|
|
||
| /** | ||
| * Interface AddCartItemInterface | ||
| * @api | ||
| */ | ||
| interface AddCartItemInterface | ||
| { | ||
| /** | ||
| * Add the specified cart item. | ||
| * | ||
| * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem The item. | ||
| * @return \Magento\Quote\Api\Data\CartItemInterface Item. | ||
| * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. | ||
| * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart. | ||
| * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. | ||
| */ | ||
| public function execute(CartItemInterface $cartItem): CartItemInterface; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\Quote\Api; | ||
|
|
||
| use Magento\Quote\Api\Data\CartItemInterface; | ||
|
|
||
| /** | ||
| * Interface UpdateCartItemInterface | ||
|
There was a problem hiding this comment. Please provide meaningful description for interface |
||
| * @api | ||
| */ | ||
| interface UpdateCartItemInterface | ||
| { | ||
| /** | ||
| * Update the specified cart item. | ||
| * | ||
| * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem The item. | ||
| * @return \Magento\Quote\Api\Data\CartItemInterface Item. | ||
| * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. | ||
| * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart. | ||
| * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. | ||
| */ | ||
| public function execute(CartItemInterface $cartItem): CartItemInterface; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\Quote\Model\Quote\Item; | ||
|
|
||
| use Magento\Quote\Api\AddCartItemInterface; | ||
| use Magento\Quote\Api\Data\CartItemInterface; | ||
|
|
||
| /** | ||
| * Add the specified cart item | ||
| */ | ||
| class AddCartItem implements AddCartItemInterface | ||
| { | ||
| /** | ||
| * @var Repository | ||
| */ | ||
| private $quoteItemRepository; | ||
|
|
||
| /** | ||
| * @param Repository $quoteItemRepository | ||
| */ | ||
| public function __construct(Repository $quoteItemRepository) | ||
| { | ||
| $this->quoteItemRepository = $quoteItemRepository; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function execute(CartItemInterface $cartItem): CartItemInterface | ||
| { | ||
| if (isset($cartItem[CartItemInterface::KEY_ITEM_ID])) { | ||
| unset($cartItem[CartItemInterface::KEY_ITEM_ID]); | ||
| } | ||
|
|
||
| return $this->quoteItemRepository->save($cartItem); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\Quote\Model\Quote\Item; | ||
|
|
||
| use Magento\Quote\Api\Data\CartItemInterface; | ||
| use Magento\Quote\Api\UpdateCartItemInterface; | ||
|
|
||
| /** | ||
| * Update the specified cart item | ||
| */ | ||
| class UpdateCartItem implements UpdateCartItemInterface | ||
| { | ||
| /** | ||
| * @var Repository | ||
| */ | ||
| private $quoteItemRepository; | ||
|
|
||
| /** | ||
| * @param Repository $quoteItemRepository | ||
| */ | ||
| public function __construct(Repository $quoteItemRepository) | ||
| { | ||
| $this->quoteItemRepository = $quoteItemRepository; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function execute(CartItemInterface $cartItem): CartItemInterface | ||
| { | ||
| return $this->quoteItemRepository->save($cartItem); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\Bundle\Api; | ||
|
|
||
| use Magento\Catalog\Model\Product; | ||
| use Magento\Framework\Webapi\Rest\Request; | ||
| use Magento\Quote\Model\Quote; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
| use Magento\TestFramework\ObjectManager; | ||
| use Magento\TestFramework\TestCase\WebapiAbstract; | ||
|
|
||
| /** | ||
| * API test for add cart item with bundle product. | ||
| */ | ||
| class CartItemAddTest extends WebapiAbstract | ||
| { | ||
| const SERVICE_VERSION = 'V1'; | ||
| const SERVICE_NAME = 'quoteAddCartItemV1'; | ||
| const RESOURCE_PATH = '/V1/carts/'; | ||
|
|
||
| /** | ||
| * @var ObjectManager | ||
| */ | ||
| protected $objectManager; | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| protected function setUp(): void | ||
| { | ||
| $this->objectManager = Bootstrap::getObjectManager(); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php | ||
| * @magentoApiDataFixture Magento/Bundle/_files/product.php | ||
| */ | ||
| public function testAddItem(): void | ||
| { | ||
| /** @var Product $product */ | ||
| $product = $this->objectManager->create(Product::class)->load(3); | ||
| /** @var Quote $quote */ | ||
| $quote = $this->objectManager->create(Quote::class)->load( | ||
| 'test_order_1', | ||
| 'reserved_order_id' | ||
| ); | ||
|
|
||
| $itemQty = 1; | ||
| $bundleProductOptions = $product->getExtensionAttributes()->getBundleProductOptions(); | ||
| $bundleOptionId = $bundleProductOptions[0]->getId(); | ||
| $optionSelections = $bundleProductOptions[0]->getProductLinks()[0]->getId(); | ||
| $buyRequest = [ | ||
| 'bundle_option' => [$bundleOptionId => [$optionSelections]], | ||
| 'bundle_option_qty' => [$bundleOptionId => 1], | ||
| 'qty' => $itemQty, | ||
| 'original_qty' => $itemQty, | ||
| ]; | ||
|
|
||
| $productSku = $product->getSku(); | ||
| $productId = $product->getId(); | ||
| $cartId = $quote->getId(); | ||
|
|
||
| $serviceInfo = [ | ||
| 'rest' => [ | ||
| 'resourcePath' => self::RESOURCE_PATH . $cartId . '/items', | ||
| 'httpMethod' => Request::HTTP_METHOD_POST, | ||
| ], | ||
| 'soap' => [ | ||
| 'service' => self::SERVICE_NAME, | ||
| 'serviceVersion' => self::SERVICE_VERSION, | ||
| 'operation' => self::SERVICE_NAME . 'Execute', | ||
| ], | ||
| ]; | ||
|
|
||
| $requestData = [ | ||
| "cartItem" => [ | ||
| "sku" => $productSku, | ||
| "qty" => $itemQty, | ||
| "quote_id" => $cartId, | ||
| "product_option" => [ | ||
| "extension_attributes" => [ | ||
| "bundle_options" => [ | ||
| [ | ||
| "option_id" => (int)$bundleOptionId, | ||
| "option_qty" => $itemQty, | ||
| "option_selections" => [(int)$optionSelections], | ||
| ], | ||
| ], | ||
| ], | ||
| ], | ||
| ], | ||
| ]; | ||
| $response = $this->_webApiCall($serviceInfo, $requestData); | ||
| $this->assertTrue($quote->hasProductId($productId)); | ||
| $this->assertEquals($buyRequest, $quote->getItemById($response['item_id'])->getBuyRequest()->getData()); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide meaningful description for interface