Skip to content

[Hub apps] Create the hub-storage module for storage setup #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Apr 9, 2025

🛠️ Description

Creates a placeholder for the hub-storage module that will eventually be used for creating containers and uploading files.

This does not create the storage account. Underlying resources will be created in the hub-app module. This PR doesn't change what's created. It only establishes the underlying infrastructure to perform the same tasks.

Related to #1400

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-04 - April milestone Apr 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 9, 2025
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Apr 9, 2025
@flanakin flanakin changed the title Create a hub-storage bicep module as a placeholder for storage setup [Hub apps] Create a hub-storage bicep module as a placeholder for storage setup Apr 9, 2025
@flanakin flanakin changed the title [Hub apps] Create a hub-storage bicep module as a placeholder for storage setup [Hub apps] Create the hub-storage module for storage setup Apr 10, 2025
@flanakin flanakin enabled auto-merge (squash) April 10, 2025 07:16
@flanakin flanakin added the Skill: Deployment Resource deployment automation via bicep or terraform label Apr 10, 2025
@MSBrett MSBrett added Status: ▶️ Ready Issue is ready for a dev to start work and removed Needs: Review 👀 PR that is ready to be reviewed labels Apr 14, 2025
@flanakin flanakin merged commit f96fa24 into dev Apr 15, 2025
1 check passed
@flanakin flanakin deleted the flanakin/dev/hubapps-stmod branch April 15, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skill: Deployment Resource deployment automation via bicep or terraform Status: ▶️ Ready Issue is ready for a dev to start work Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants