Skip to content

FinOps alerts fix for deployment bug #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025
+14 −8
Merged

FinOps alerts fix for deployment bug #1511

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f75657b
fixes for deployment bug
ro100e Apr 11, 2025
e04fe1c
Update src/templates/finops-alerts/modules/logicApp.bicep
ro100e Apr 13, 2025
6ef6895
Update src/templates/finops-alerts/modules/logicApp.bicep
ro100e Apr 13, 2025
a0c5438
update changelog
ro100e Apr 13, 2025
d63cbc9
Merge branches 'robelm/finops-alerts-patch-1' and 'robelm/finops-aler…
ro100e Apr 13, 2025
2fa974c
Merge branch 'dev' into robelm/finops-alerts-patch-1
flanakin Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs-mslearn/toolkit/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ The following section lists features and enhancements that are currently in deve
**Fixed**
- Workaround subnets reordering and bicep limitation

### [FinOps alerts](alerts/finops-alerts-overview.md) pending updates

- **Fixed**
- Update the 'id' property for the managedApi to a valid scope
- This caused a deployment error because the path could not be deserialized.

<br><a name="latest"></a>

## v0.9 Update 1
Expand Down
6 changes: 3 additions & 3 deletions src/templates/finops-alerts/modules/logicApp.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3729,7 +3729,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
{
name: 'resourcesTable'
type: 'string'
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(string(variables(\'IncludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(string(variables(\'ExcludedSubscriptions\')), \'[\', \'\'), \']\', \'\'), \'")\'))}'
value: 'resources@{if(equals(length(variables(\'IncludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId in ("\', replace(replace(replace(string(variables(\'IncludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}@{if(equals(length(variables(\'ExcludedSubscriptions\')), 0), \'\', concat(\'| where subscriptionId !in ("\', replace(replace(replace(string(variables(\'ExcludedSubscriptions\')), \'\\n\', \'\'), \'[\', \'\'), \']\', \'\'), \'")\'))}'
}
]
}
Expand Down Expand Up @@ -4183,7 +4183,7 @@ resource finopsAlerts 'Microsoft.Logic/workflows@2019-05-01' = {
office365: {
connectionId: apiConnection.id
connectionName: connectionName
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
}
}
}
Expand All @@ -4201,7 +4201,7 @@ resource apiConnection 'Microsoft.Web/connections@2016-06-01' = {
location: location
properties: {
api: {
id: resourceId('Microsoft.Web/locations/managedApis', location, 'office365')
id: subscriptionResourceId('Microsoft.Web/locations/managedApis', location, 'office365')
}
displayName:displayName
}
Expand Down