Skip to content

chore: modify konflux pipeline to use remote ref #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: modify konflux pipeline to use remote ref #1224

wants to merge 1 commit into from

Conversation

avinal
Copy link
Member

@avinal avinal commented Apr 23, 2025

Changes

  • added CEL expressions
  • added remote reference for pipelines

@openshift-ci openshift-ci bot requested review from jkhelil and sayan-biswas April 23, 2025 10:29
@avinal avinal mentioned this pull request Apr 23, 2025
Open
@avinal avinal force-pushed the appstudio-source-to-image-rhel9 branch from 11469b5 to 8ed2240 Compare April 23, 2025 10:32
sayan-biswas
sayan-biswas suggested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@sayan-biswas sayan-biswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs to change the component name though.

@avinal avinal force-pushed the appstudio-source-to-image-rhel9 branch from 8ed2240 to 7447196 Compare April 24, 2025 11:11
@sayan-biswas
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@sayan-biswas sayan-biswas mentioned this pull request May 19, 2025
Closed
1 task
@sayan-biswas sayan-biswas force-pushed the appstudio-source-to-image-rhel9 branch 2 times, most recently from a6dfff1 to 9a4a664 Compare May 19, 2025 18:34
@avinal @sayan-biswas
chore: modify konflux pipeline to use remote ref
1fbf9cf 
- added CEL expressions
- added remote reference for pipelines
- Added service accounts

Signed-off-by: Avinal Kumar <avinal@redhat.com>
@sayan-biswas sayan-biswas force-pushed the appstudio-source-to-image-rhel9 branch from 9a4a664 to 1fbf9cf Compare May 20, 2025 10:00
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@avinal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1fbf9cf link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayan-biswas sayan-biswas sayan-biswas approved these changes

@jkhelil jkhelil Awaiting requested review from jkhelil

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avinal @sayan-biswas