Add advisory for index error in mp3-metadata #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuillaumeGomez r? Any thoughts? |
|
Confirmed. I fixed the issue and added a regression test. |
|
IMO it would be nice to have a bit more context around the actual issue -- how was the panic triggered (in terms of library semantics), ideally even adding affected function calls if possible. I don't think most of the audience will care that it was found via a fuzzer (except that it sort of diminishes the impact, I suppose, if it wasn't found in the real world), and that it was fixed is pretty obvious too. |
|
@djc You are right! I have updated more information for the advisory. |
|
Did some further editing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.