Skip to content

Add advisory for index error in mp3-metadata #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions crates/mp3-metadata/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "mp3-metadata"
date = "2025-04-28"
url = "https://github.com/GuillaumeGomez/mp3-metadata/issues/36"
informational = "unsound"
categories = ["denial-of-service"]

[affected]
functions = {"mp3_metadata::read_from_slice" = ["< 0.4.0"]}

[versions]
patched = ["0.4.0"]
```

# Panic in mp3-metadata due to the lack of bounds checking

The `get_id3()` methods used by `mp3_metadata::read_from_slice()` does not perform adequate bounds
checking when recreating the tag due to the use of desynchronization.

Fixed in [Fix index error](https://github.com/GuillaumeGomez/mp3-metadata/pull/37), released as
part of 0.4.0.