Skip to content

fix(Modal): nested modals scroll #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

fix(Modal): nested modals scroll #5091

merged 1 commit into from
May 19, 2025

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented May 2, 2025

Summary

Type

  • Bug

Summarise concisely:

Fix scroll in nested modals

@lisalupi lisalupi added the bug Something isn't working label May 2, 2025
@lisalupi lisalupi requested a review from a team May 2, 2025 14:52
@lisalupi lisalupi self-assigned this May 2, 2025
@lisalupi lisalupi requested review from johnrazeur and Lawndlwd and removed request for a team May 2, 2025 14:52
@lisalupi lisalupi requested a review from matthprost as a code owner May 2, 2025 14:52
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 46e8fd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (30687b4) to head (46e8fd9).
Report is 55 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5091      +/-   ##
==========================================
+ Coverage   88.69%   88.71%   +0.02%     
==========================================
  Files         236      236              
  Lines        8338     8347       +9     
  Branches     3739     3741       +2     
==========================================
+ Hits         7395     7405      +10     
+ Misses        943      942       -1     
Files with missing lines Coverage Δ
...ages/ui/src/components/Modal/components/Dialog.tsx 75.86% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5705e3c...46e8fd9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@lisalupi lisalupi merged commit 6c8f8af into main May 19, 2025
16 checks passed
@lisalupi lisalupi deleted the fix/nested-modal branch May 19, 2025 12:23
@scaleway-bot scaleway-bot mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants