Skip to content

fix(Modal): nested modals scroll #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

fix(Modal): nested modals scroll #5091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/all-apes-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

`<Modal />` fix scroll in nested modals when the content is too long
8 changes: 0 additions & 8 deletions packages/ui/src/components/Drawer/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,6 @@ exports[`Drawer > renders with disclosure and onClose 1`] = `
opacity: 1;
}

.emotion-0[data-animation='true'] {
overflow: hidden;
}

.emotion-0 {
position: fixed;
top: 0;
Expand Down Expand Up @@ -363,10 +359,6 @@ exports[`Drawer > renders with disclosure and onClose 1`] = `
opacity: 1;
}

.emotion-0[data-animation='true'] {
overflow: hidden;
}

.emotion-3 {
background-color: #ffffff;
position: relative;
Expand Down
30 changes: 29 additions & 1 deletion packages/ui/src/components/Modal/__stories__/NestedModal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,35 @@ export const NestedModal: StoryFn = props => (
pariatur. Excepteur sint occaecat cupidatat non proident, sunt in
culpa qui officia deserunt mollit anim id est laborum.
<Modal {...props} disclosure={<Button>Open Children Modal</Button>}>
Children Children Modal Lorem ipsum dolor sit amet, consectetur
<strong>Children Children Modal with long content</strong> Lorem
ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex
ea commodo consequat. Duis aute irure dolor in reprehenderit in
voluptate velit esse cillum dolore eu fugiat nulla pariatur.
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui
officia deserunt mollit anim id est laborum. Lorem ipsum dolor sit
amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt
ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis
nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
consequat. Duis aute irure dolor in reprehenderit in voluptate velit
esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat
cupidatat non proident, sunt in culpa qui officia deserunt mollit
anim id est laborum. Lorem ipsum dolor sit amet, consectetur
adipiscing elit. Sed do eiusmod tempor incididunt ut labore et
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud
exercitation ullamco laboris nisi ut aliquip ex ea commodo
consequat. Duis aute irure dolor in reprehenderit in voluptate velit
esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat
cupidatat non proident, sunt in culpa qui officia deserunt mollit
anim id est laborum. Lorem ipsum dolor sit amet, consectetur
adipiscing elit. Sed do eiusmod tempor incididunt ut labore et
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud
exercitation ullamco laboris nisi ut aliquip ex ea commodo
consequat. Duis aute irure dolor in reprehenderit in voluptate velit
esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat
cupidatat non proident, sunt in culpa qui officia deserunt mollit
anim id est laborum. Lorem ipsum dolor sit amet, consectetur
adipiscing elit. Sed do eiusmod tempor incididunt ut labore et
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud
exercitation ullamco laboris nisi ut aliquip ex ea commodo
Expand Down
8 changes: 0 additions & 8 deletions packages/ui/src/components/Modal/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,6 @@ exports[`Modal > renders with disclosure and onClose 1`] = `
opacity: 1;
}

.emotion-0[data-animation='true'] {
overflow: hidden;
}

.emotion-0 {
position: fixed;
top: 0;
Expand Down Expand Up @@ -227,10 +223,6 @@ exports[`Modal > renders with disclosure and onClose 1`] = `
opacity: 1;
}

.emotion-0[data-animation='true'] {
overflow: hidden;
}

.emotion-2 {
background-color: #ffffff;
position: relative;
Expand Down
5 changes: 1 addition & 4 deletions packages/ui/src/components/Modal/components/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ const StyledBackdrop = styled.div<{ 'data-open': boolean }>`
opacity: 1;
}

&[data-animation='true'] {
overflow: hidden;
}

`

type StyledDialogProps = {
Expand All @@ -84,6 +80,7 @@ export const StyledDialog = styled('dialog', {
padding: ${({ theme }) => theme.space['3']};
width: ${MODAL_WIDTH.medium}rem;
box-shadow: ${({ theme }) => `${theme.shadows.overlay[0]}, ${theme.shadows.overlay[1]}`};



${Object.entries(MODAL_WIDTH).map(
Expand Down
Loading