Skip to content

chore: fix C lint errors (issue #6313) #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Mar 23, 2025

Resolves #6313

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: JaySoni1 <jaygsoni14@gmail.com>
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 23, 2025
@JaySoni1 JaySoni1 changed the title chore: Fix C lint errors #6313 chore: fix C lint errors (issue #6313) Mar 23, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: JaySoni1 <jaygsoni14@gmail.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 23, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/signum 178 / 178
+ 100.00 %
10 / 10
+ 100.00 %
2 / 2
+ 100.00 %
178 / 178
+ 100.00 %

The above coverage report was generated for the changes in this PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: JaySoni1 <jaygsoni14@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: JaySoni1 <jaygsoni14@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: JaySoni1 <jaygsoni14@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not valid. You need to spend more time studying our codebase. The necessary change is a trivial comment to suppress a lint error. You can find numerous examples in other packages.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants