Skip to content

chore: fix C lint errors (issue #6313) #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

chore: fix C lint errors (issue #6313) #6319

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9947303
Update addon.c
JaySoni1 Mar 23, 2025
6557468
Update addon.c
JaySoni1 Mar 23, 2025
fbf3499
Update addon.c
JaySoni1 Mar 23, 2025
9cbd392
Update addon.c
JaySoni1 Mar 23, 2025
6ad6b16
Update addon.c
JaySoni1 Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/node_modules/@stdlib/math/base/special/signum/src/addon.c
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not valid. You need to spend more time studying our codebase. The necessary change is a trivial comment to suppress a lint error. You can find numerous examples in other packages.

Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@
#include "stdlib/math/base/special/signum.h"
#include "stdlib/math/base/napi/unary.h"

STDLIB_MATH_BASE_NAPI_MODULE_D_D( stdlib_base_signum )
// Wrapper function that calls the actual implementation
static double signum_callback( const double x ) {
return stdlib_base_signum( x );
}

// Export the wrapper with a unique symbol name to avoid shadowing
STDLIB_MATH_BASE_NAPI_MODULE_D_D( signum_module, signum_callback )
Loading