[tmpnet] Provide genesis, subnet and chain config via content flags #3857

maru-ava · 2025-03-31T21:05:01Z

PR Chain: tmpnet+kube

This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.

Why this should be merged

Previously supplied genesis, subnet and chain config to nodes via --*-file-content flags pointing to files on disk. Switching to use the equivalent --*-content flags simplifies configuring nodes deployed to kube where configuration via files is more complicated.

To support this, Node.Flags is now used only for generated configuration like keys and user-supplied node-specific config. Network defaults and automatic configuration (like bootstrap IPs/IDs) are not included. Instead, flags.json for each node is generated each time a node is started to ensure that the configuration is up-to-date.

How this was tested

CI, local validation of tmpnetctl start-network

Need to be documented in RELEASES.md?

N/A

maru-ava · 2025-03-31T21:05:51Z

tests/fixture/tmpnet/defaults.go

@@ -50,6 +50,9 @@ func DefaultTestFlags() FlagsMap {
 func DefaultTmpnetFlags() FlagsMap {
 	// Supply only non-default configuration to ensure that default values will be used.
 	flags := FlagsMap{
+		// Default to dynamic port allocation


This used to be set every time a node started, but is more properly a network default.

maru-ava · 2025-03-31T21:07:12Z

tests/fixture/tmpnet/network.go

@@ -101,6 +105,9 @@ type Network struct {
 	// Genesis for the network. If nil, NetworkID must be non-zero
 	Genesis *genesis.UnparsedConfig

+	// Configuration for primary subnets
+	PrimarySubnetConfigs map[ids.ID]subnets.Config


Previously the only way to provide a subnet config was to create a file [network dir]/subnets/[subnet id].json after a network was already created. Now it's possible to configure this in code without touching the filesystem.

maru-ava · 2025-03-31T21:15:43Z

tests/fixture/tmpnet/network_config.go

@@ -110,65 +106,6 @@ func (n *Network) writeGenesis() error {
 	return nil
 }

-func (n *Network) GetChainConfigDir() string {


Chain configuration is now written to the filesystem separate from the subnet configuration files

maru-ava · 2025-03-31T21:16:56Z

tests/fixture/tmpnet/subnet.go

@@ -51,32 +51,12 @@ type Chain struct {
 	PreFundedKey *secp256k1.PrivateKey
 }

-// Write the chain configuration to the specified directory.


Subnet configuration for avalanchego is no longer written to the filesystem

maru-ava · 2025-03-31T21:18:43Z

tests/fixture/tmpnet/node_config.go

@@ -22,21 +22,8 @@ func (n *Node) GetFlagsPath() string {
 	return filepath.Join(n.GetDataDir(), "flags.json")
 }

-func (n *Node) readFlags() error {


Previously flags.json was the only way that node flags were stored. Now non-default node flags are stored in the node configuration file (config.json) and flags.json is write-only and written every time a node is started

maru-ava · 2025-03-31T21:20:02Z

tests/fixture/tmpnet/node.go

@@ -154,6 +155,11 @@ func ReadNodes(networkDir string, includeEphemeral bool) ([]*Node, error) {
 			continue
 		}

+		// Ensure the node ID is set
+		if err := node.EnsureNodeID(); err != nil {


Ensuring the node ID is derived from the keys was previously done by Node.readFlags

qdm12

Nice 👍 Just leaving a few nitpicky comments which you can ignore as well 😉 !

tests/fixture/tmpnet/flags.go

tests/fixture/tmpnet/network.go

tests/fixture/tmpnet/node.go

Previously supplied genesis, subnet and chain config to nodes via `--*-file-content` flags pointing to files on disk. Switching to use the equivalent `--*-content` flags simplifies configuring nodes deployed to kube where configuration via files is more complicated. To support this, Node.Flags is now used only for generated configuration like keys and user-supplied node-specific config. Network defaults and automatic configuration (like bootstrap IPs/IDs) are not included. Instead, flags.json for each node is generated each time a node is started to ensure that the configuration is up-to-date.

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

tests/fixture/tmpnet/flags.go

tests/fixture/tmpnet/network.go

felipemadero

Overall LGTM. Just a naming nit and a couple of suggestions which scope anyway may belong to a different PR.

tests/fixture/tmpnet/network.go

tests/fixture/tmpnet/network_config.go

maru-ava added the testing This primarily focuses on testing label Mar 31, 2025

maru-ava self-assigned this Mar 31, 2025

maru-ava added this to avalanchego Mar 31, 2025

github-project-automation bot moved this to Backlog 🗄️ in avalanchego Mar 31, 2025

maru-ava moved this from Backlog 🗄️ to In Review 👀 in avalanchego Mar 31, 2025

maru-ava commented Mar 31, 2025

View reviewed changes

maru-ava force-pushed the tmpnet-use-content-keys branch 2 times, most recently from e3f3c9d to c8ddf75 Compare March 31, 2025 21:14

maru-ava commented Mar 31, 2025

View reviewed changes

maru-ava force-pushed the tmpnet-use-content-keys branch from c8ddf75 to 2143fe1 Compare April 1, 2025 00:11

maru-ava requested a review from felipemadero April 1, 2025 00:37

qdm12 approved these changes Apr 2, 2025

View reviewed changes

maru-ava and others added 13 commits April 7, 2025 11:23

Update tests/fixture/tmpnet/network.go

d4bb6a7

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

5374eed

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

38d5b46

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

e3ef91b

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/node.go

b0c5c2a

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

4d28a32

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

fc20c26

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

ff32c06

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

47c626d

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

124687d

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

Update tests/fixture/tmpnet/network.go

422be6b

Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>

fixup: respond to reviewer feedback

9d3759a

maru-ava force-pushed the tmpnet-use-content-keys branch from 38e4eb5 to 9d3759a Compare April 7, 2025 18:23

qdm12 reviewed Apr 8, 2025

View reviewed changes

tests/fixture/tmpnet/flags.go Show resolved Hide resolved

tests/fixture/tmpnet/network.go Outdated Show resolved Hide resolved

tests/fixture/tmpnet/network.go Outdated Show resolved Hide resolved

tests/fixture/tmpnet/network.go Show resolved Hide resolved

felipemadero reviewed Apr 8, 2025

View reviewed changes

tests/fixture/tmpnet/network.go Outdated Show resolved Hide resolved

tests/fixture/tmpnet/network.go Outdated Show resolved Hide resolved

tests/fixture/tmpnet/network.go Outdated Show resolved Hide resolved

tests/fixture/tmpnet/network_config.go Show resolved Hide resolved

fixup: Respond to more reviewer feedback

823336a

maru-ava force-pushed the tmpnet-use-content-keys branch from 1edd5c5 to 823336a Compare April 8, 2025 18:19

fixup: Minor writeNodeFlags cleanup

8e550da

felipemadero approved these changes Apr 8, 2025

View reviewed changes

fixup: Ensure compatibility for tests of staking logic

b36e1a3

maru-ava added this pull request to the merge queue Apr 9, 2025

Merged via the queue into master with commit 7a4694a Apr 9, 2025
24 checks passed

maru-ava deleted the tmpnet-use-content-keys branch April 9, 2025 04:09

github-project-automation bot moved this from In Review 👀 to Done ✅ in avalanchego Apr 9, 2025

aaronbuchwald mentioned this pull request Apr 10, 2025

Update avalanchego to latest commit ava-labs/hypersdk#2022

Merged

maru-ava mentioned this pull request May 7, 2025

[tmpnet] Define reusable flags for configuring kubernetes client access #3945

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tmpnet] Provide genesis, subnet and chain config via content flags #3857

[tmpnet] Provide genesis, subnet and chain config via content flags #3857

maru-ava commented Mar 31, 2025 •

edited

Loading

maru-ava Mar 31, 2025

maru-ava Mar 31, 2025

maru-ava Mar 31, 2025 •

edited by qdm12

Loading

maru-ava Mar 31, 2025

maru-ava Mar 31, 2025

maru-ava Mar 31, 2025

qdm12 left a comment •

edited

Loading

felipemadero left a comment

[tmpnet] Provide genesis, subnet and chain config via content flags #3857

[tmpnet] Provide genesis, subnet and chain config via content flags #3857

Conversation

maru-ava commented Mar 31, 2025 • edited Loading

PR Chain: tmpnet+kube

Why this should be merged

How this was tested

Need to be documented in RELEASES.md?

maru-ava Mar 31, 2025

Choose a reason for hiding this comment

maru-ava Mar 31, 2025

Choose a reason for hiding this comment

maru-ava Mar 31, 2025 • edited by qdm12 Loading

Choose a reason for hiding this comment

maru-ava Mar 31, 2025

Choose a reason for hiding this comment

maru-ava Mar 31, 2025

Choose a reason for hiding this comment

maru-ava Mar 31, 2025

Choose a reason for hiding this comment

qdm12 left a comment • edited Loading

Choose a reason for hiding this comment

felipemadero left a comment

Choose a reason for hiding this comment

maru-ava commented Mar 31, 2025 •

edited

Loading

maru-ava Mar 31, 2025 •

edited by qdm12

Loading

qdm12 left a comment •

edited

Loading