[tmpnet] Move WaitForHealthy from a function to a tmpnet.Node method #3896
+38
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the WaitForHealthy function by moving it from a global utility in tmpnet/utils.go to a method on the Node struct, allowing for cleaner, object-oriented calls.
- Moved WaitForHealthy function from tmpnet/utils.go to Node struct in tmpnet/node.go
- Updated call sites in network.go, e2e helpers, and duplicate node ID fault injection tests to use the new Node method
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/fixture/tmpnet/utils.go | Removed the global WaitForHealthy function |
| tests/fixture/tmpnet/node.go | Introduced Node.WaitForHealthy with improved error logging |
| tests/fixture/tmpnet/network.go | Updated to call Node.WaitForHealthy instead of the removed util |
| tests/fixture/e2e/helpers.go | Replaced call to global WaitForHealthy with Node.WaitForHealthy |
| tests/e2e/faultinjection/duplicate_node_id.go | Updated WaitForHealthy call to use the Node method |
maru-ava
changed the title
1 task
qdm12
approved these changes
Apr 18, 2025
joshua-kim
approved these changes
Apr 18, 2025
maru-ava
force-pushed
the
tmpnet-ensure-context
branch
2 times, most recently
from
a61bdec to
8511fd9
Compare
maru-ava
force-pushed
the
tmpnet-move-waitforhealthy
branch
from
9c8d963 to
ce11d86
Compare
|
Rebased |
This was referenced Apr 28, 2025
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
Nicer to be able to call
node.WaitForHealthy(ctx)instead oftmpnet.WaitForHealthy(ctx, node).How this was tested
CI
Need to be documented in RELEASES.md?
N/A
TODO