Skip to content

[tmpnet] Ensure Node has a reference to Network #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Apr 9, 2025

PR Chain: tmpnet+kube

This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.

Why this should be merged

Previously tmpnet.Node was serialized with a subset of tmpnet.Network fields like UUID and Owner. Intead, tmpnet.Node gets a reference to its owning tmpnet.Network on read or start to ensure it has full access to all network details.

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

Previously tmpnet.Node was serialized with a subset of tmpnet.Network
fields like UUID and Owner. Intead, tmpnet.Node gets a reference to
its owning tmpnet.Network on read or start to ensure it has full
access to all network details.
@maru-ava maru-ava self-assigned this Apr 9, 2025
@github-project-automation github-project-automation bot moved this to Backlog 🗄️ in avalanchego Apr 9, 2025
@maru-ava maru-ava moved this from Backlog 🗄️ to In Review 👀 in avalanchego Apr 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@maru-ava maru-ava added this pull request to the merge queue Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants