Skip to content

🧪 Extract non-pbr logic from bevy_pbr #18637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

🧪 Extract non-pbr logic from bevy_pbr #18637

wants to merge 6 commits into from

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented Mar 31, 2025 •
edited
Loading

Objective

Extract non-pbr code from bevy_pbr as part of #18423
Also fixes #18343

Solution

Move code from bevy_pbr that is not exclusive to pbr into bevy_render_3d

Testing

Just cargo run -p ci

TODO

  • Better organize shaders
  • Update import paths of shaders
  • Migration guide

@github-actions GitHub Actions
Copy link
Contributor

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 31, 2025
@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Mar 31, 2025
@alice-i-cecile
Copy link
Member

Strongly in favor of this general direction BTW: label is just because this sort of code shuffling often provokes bikeshedding. Ping me when this is ready please.

@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Mar 31, 2025
@hukasu hukasu mentioned this pull request Apr 3, 2025
Open
1 task
aloucks
aloucks reviewed Apr 8, 2025
View reviewed changes
crates/bevy_render_3d/src/material.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this move temporary? I thought the recommendation was to move the material abstraction to bevy_material.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this crate has more than just the material abstraction, if it is going to be broken further after this is for the higher-ups to decide

@hukasu hukasu changed the title Extract non-pbr logic from bevy_pbr 🧪 Extract non-pbr logic from bevy_pbr Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloucks aloucks aloucks left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Contentious There are nontrivial implications that should be thought through
Projects
Rendering
Status: No status
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

Redo #17581, removing bevy_pbr dependency in bevy_gizmos
3 participants
@hukasu @alice-i-cecile @aloucks