Remove ArchetypeComponentId and archetype_component_access

[chescock]

Objective

Remove ArchetypeComponentId and archetype_component_access. Following #16885, they are no longer used by the engine, so we can stop spending time calculating them or space storing them.

Solution

Remove ArchetypeComponentId and everything that touches it.

The System::update_archetype_component_access method no longer needs to update archetype_component_access. We do still need to update query caches, but we no longer need to do so before running the system. We'd have to touch every caller anyway if we gave the method a better name, so just remove System::update_archetype_component_access and SystemParam::new_archetype entirely, and update the query cache in Query::get_param.

The Single and Populated params also need their query caches updated in SystemParam::validate_param, so change validate_param to take &mut Self::State instead of &Self::State.

[ElliottjPierce]

Easy approve! Everything looks good to me.

[ItsDoot]

I like it! This should make queries as entities straightforward now, right?

Some stats on memory savings on 64-bit systems:

• -8 bytes per component per archetype
• -8 bytes per resource
• -4 bytes per system (SystemState)
• at least -128 bytes per system (SystemMeta)
• at least -128 bytes per combinator system
• at least -128 bytes per pipe system