enable wayland by default #19232
Open
enable wayland by default #19232
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBrienen
requested review from
Vrixyz,
TimJentzsch,
Trashtalk217,
alice-i-cecile and
JMS55
BenjaminBrienen
added
D-Trivial
Trashtalk217
approved these changes
May 16, 2025
Vrixyz
approved these changes
May 16, 2025
TimJentzsch
approved these changes
May 16, 2025
There was a problem hiding this comment.
Binary size of the breakout example:
- Without wayland: 71,596,288
- With wayland: 73,349,376 (+2.44%)
Personally, I think that's acceptable, considering the benefits.
The usage seems to be at 45% now, so it could benefit a lot of users.
TimJentzsch
added
S-Ready-For-Final-Review
janhohenheim
approved these changes
May 16, 2025
|
Maybe related? |
alice-i-cecile
added
X-Controversial
|
@cart has argued against this in the past, but things have continued to develop and user feedback has been anecdotally good. I'm weakly in favor, but I'll leave the final call to him. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Just one commit to add
waylandto the default features indeedWhy should it be merged?
The discussion in #4106 seems to be overwhelmingly positive toward adding
waylandto the default features, as it can greatly improve user experience for Linux users who use Wayland.Many of the most popular Linux Desktop Environments (DE) like KDE Plasma Desktop and GNOME have Wayland support. With the release of Plasma 6, Wayland is now used by default, and in GNOME, Wayland has been the default for quite a while now.
With Plasma and GNOME, the most popular Linux DEs, now defaulting to Wayland, it seems like enabling Wayland support would truly indeed positively affect quite a lot of Linux users indeed.
Copied from #10792